gaaclarke

Results 150 comments of gaaclarke

Your description talks about an api `registerIsolateCallback` but that doesn't exist in the PR. Can you update your description? A hard requirement for this feature is going to be compatibility...

I don't recommend this PR because it expands the API surface for the services package in a way that is complicated. The complication should be bore by the flutter developers...

> @gaaclarke I can adapt the change for the proposed API, my question would be. > > Is there any lifecycle hook on the isolate that would be called just...

The mock test executed correctly, but on the next release the PR that sets the release name did not seem to reap the golden results like what happened in the...

I double checked the cocoon code to make sure the logic for running skia gold was still intact. It is. - https://github.com/flutter/cocoon/blob/c792fa3737d5f119a783048bb97c3c0d51959dc8/app_dart/lib/src/service/config.dart#L70 - https://github.com/flutter/cocoon/blob/c792fa3737d5f119a783048bb97c3c0d51959dc8/app_dart/lib/src/request_handlers/push_gold_status_to_github.dart#L81 It seems like the conditions that...

I looked through the code a bit and I believe we are running into an x-factor between the environment where the mock release can be run and the actual releases....

@jonahwilliams Do we need to bisect this still? It's been months. I think bisecting will only help us if we want to cherry-pick. Let me know and I can do...

Hey @flutterfromscratch, it's my understanding that the Windows API is still in flux. Moreso than the other experimental generators. I know less about it since my colleague is leading that...

@flutterfromscratch, I asked Stuart and they said `@HostApi` generation should be fairly stable but he plans to change`@FlutterApi` quite a bit. So if that's fine with you, that'd be awesome...