gaaclarke

Results 150 comments of gaaclarke

kOneMinusSourceAlpha is essentially a clamp to one. There's no reason to have an alpha value over 1 (here at least, maybe never?). The alpha math listed in W3C has an...

Thanks Jason, so what we know now is that the cause isn't wide gamut colors per se, but the alpha blend calculation for the `Plus` blend when the pixel format...

> Plus is used by the framework to do color lerps in decoration images: > > https://github.com/flutter/flutter/blob/1c153c38d2fca7e9a74a02d2971feda1620dcc88/packages/flutter/lib/src/painting/decoration_image.dart#L750 Because the usage is blend with `plus` then restore I think the `kOneMinusSourceAlpha`...

So, switching plus's alpha blend function makes the results 8x more accurate and is correct for alpha = 1 or 0. I think we should make this an advanced blend...

I created a PR that implements plus as an advanced blend and reproduced jasons test which it passes: https://github.com/flutter/engine/pull/51589 We still need to figure out how we want to do...

If you use swiftshader on linux, there is a whole different error: ``` [ RUN ] Play/AiksTest.GaussianBlurAllocatesCorrectMipCountRenderTarget/Vulkan error: XDG_RUNTIME_DIR not set in the environment. error: XDG_RUNTIME_DIR not set in the...

> @gaaclarke LMK if you get a chance to try out the patch to confirm that it works, and I will clean it up and add tests. @jonahwilliams this is...

Ooo cool, looks promising. "IWYU" sounds right. The sample output sounds right too. Nice find.

I opened "jitter sample" trace and looked at the frame times for the "Built-in Display" probe for the time the app is launched versus the time when it comes back...

> Every time I stop the cpu profiler and it is processing data it crashes. You can try updating your Xcode.