ga4gh-schemas icon indicating copy to clipboard operation
ga4gh-schemas copied to clipboard

Peer service improvements

Open david4096 opened this issue 7 years ago • 4 comments

~~Move the Peer message to its own file.~~

Add a remote_address field to the GetInfoResponse which can be used to reflect on the origin of a request. This makes it easier to make well formed announce messages in mixed network environments.

david4096 avatar Mar 08 '17 01:03 david4096

I discussed this with @ejacox and I now think you were right to keep the messages together with the data. The peer service has nothing to do with the representation of genomic data. It is associated with serving the data and as such should be represented as a protocol only.

@david4096 : you responded to my questions very quickly with this PR. Thanks for your quick reaction :-) Let's go with your first design and close this PR without merging. So, -1 with apologies, since I suggested it in the first place!

kozbo avatar Mar 09 '17 01:03 kozbo

No problem, updated!

david4096 avatar Mar 09 '17 01:03 david4096

This is intended for a future release, we haven't implemented the remote_address functionality yet.

david4096 avatar Mar 09 '17 23:03 david4096

thanks @david4096

kozbo avatar Mar 09 '17 23:03 kozbo