data-repository-service-schemas icon indicating copy to clipboard operation
data-repository-service-schemas copied to clipboard

Presence of both `access_id` and `access_url` in a response

Open hannes-ucsc opened this issue 3 years ago • 4 comments

I interpret this clause of the spec

https://github.com/ga4gh/data-repository-service-schemas/blob/2425439e509b252a76d2a85b86d9fa26747addfc/openapi/data_repository_service.swagger.yaml#L343

to mean that having both access_id and access_url in a response is acceptable. Is that the case?

If so, what is the point of providing an access ID and following it in a separate request, when a URL is already available?

hannes-ucsc avatar Jul 20 '21 17:07 hannes-ucsc

Providing both access_id and access_url in a response is misleading for DRS API client and is not aligned with Fetching DRS Objects section. DRS API client MUST only work with access_url to access DRS object content. I would also like to hear more about resolving this as it is creating issues on the consumer side.

trbica avatar Jan 19 '22 11:01 trbica

I would argue the documentation that @hannes-ucsc points explicitly states that both are legitimate. Also, for signed URLs, then you would definitely not use access_url

nmalfroy avatar Jan 27 '22 17:01 nmalfroy

I'd consider the possibility that the phrase "at least one of" was a mistake and that the intent was "either one of".

hannes-ucsc avatar Jan 27 '22 17:01 hannes-ucsc

Yeah, I agree...it appears that this may be a bug in the spec wording...which would then break our implementation

nmalfroy avatar Jan 27 '22 18:01 nmalfroy