data-repository-service-schemas icon indicating copy to clipboard operation
data-repository-service-schemas copied to clipboard

Published 20 hours ago • verified publisher icon ga4gh

Implementing GA4GH service-info to DRS

Open susheel opened this issue 5 years ago • 6 comments

Resolves #309

susheel avatar Jan 28 '20 11:01 susheel

@susheel, per the CONTRIBUTING guidelines, we only submit PRs to release branches, not to master. (The main reason is to make sure the Travis CI checks get run, including rebuilding the docs, in each branch -- that way we can be sure the change doesn't break anything, and confirm that the documentation matches the intent.)

dglazer avatar Jan 28 '20 12:01 dglazer

@dglazer Done. I have rebased this PR to release/v1.0.1

susheel avatar Jan 28 '20 14:01 susheel

@susheel , I'm not an expert on the HubFlow process described in Contributing.MD, but I think the key parts are a) name your feature branch according to the required naming convention, and b) set it up to merge into develop (not a release branch, and not master). @briandoconnor can confirm.

One benefit of that is triggering the Travis CI checks; there are other benefits around the release process that I'm less familiar with.

dglazer avatar Jan 30 '20 14:01 dglazer

Done.

susheel avatar Jan 30 '20 15:01 susheel

GA4GH service-info has just tagged their release v1.0.0 which now makes this PR valid to merge, barring any build and test errors.

susheel avatar Feb 05 '20 23:02 susheel

Reviving this thread as getting /service-info in DRS has been discussed at the past few meetings.

@susheel it would be great if you are still available to work on this PR. The spec was recently migrated from Swagger to OpenAPI, so now there are some merge conflicts. Do you have the bandwidth to update your branch?

jb-adams avatar Jul 26 '21 17:07 jb-adams