specification icon indicating copy to clipboard operation
specification copied to clipboard

Move dataset_ids to separate message

Open mbaudis opened this issue 8 years ago • 2 comments

the current BeaconAlleleResponse message embeds the optional specification of dataset ids. With a foreseeable move to multiple variant and metadata message query types, it seems logical to have the datasets specified outside of the variant queries.

mbaudis avatar May 08 '17 13:05 mbaudis

I agree. But in the future... As it is an integral part of the request, I don't clearly see how to do it. Also, as these are just two "small" parameters, I suggest to go ahead duplicating them in both requests and refine it when we see how and see it fit.

jrambla avatar May 12 '17 13:05 jrambla

What would this look like encoded in proto3?

mcupak avatar Jun 13 '17 12:06 mcupak