Guillaume Delahaye

Results 120 comments of Guillaume Delahaye

> @g7ed6e I removed the Roslyn 3.11 Build.Tools project because VS2019 does not support .NET 6. Unless there is still reason to keep the project within the solution, I will...

> What about command line building? Can you use Rosslyn 3.11 at the command line to build? @mconnew As CoreWCF will target .net 6 and .net 6 requires .net 6...

thanks @mbpframework for creating the issue. I'm trying to reproduce - were the `ServiceContract` interface and implementations in the same assembly ? - what is the size of the solution...

@tskong CoreWCF pull a service from DI using its concrete type. To ensure services are registered correctly you could add to your test code `app.Services.GetService()`. I dont know Autofac much...

> I have got the same problems testing against net 7.0. Some types accessed by reflection in DataContractEx class have changed namespaces in net 7.0. For example line 89 in...

@mconnew All unit tests are successful with XsdDataContractExporter when targeting .NET 7 and .NET 472. However we still need XsdDataContractExporterEx for .NET6/5/3.1. I think the fixed .NET7 implementation is also...

> You've got the delegation the wrong way around between the async and sync methods. Think about the scenario where someone has an implementation where they already have a derived...

> Same issue as the other PR for ServiceAuthorizationManager, the default implementation needs to stay in the sync methods and have the async methods call them. I inverted the delegation...

~~@mconnew there's still an issue in this PR if someone mix the `OperationContractParameterInjector` feature from the source generator with authorization attributes. I can see 2 solutions:~~ ~~- Either the source...