nestjs-plugins icon indicating copy to clipboard operation
nestjs-plugins copied to clipboard

chore: firebase ability to use Realtime Database

Open faustman opened this issue 3 years ago • 4 comments

Hi! First time here,

The problem:

No access to Realtime Database API from the Firebase Admin SDK in the NestJS App.

The solution:

  • Added database attribute to FirebaseAdmin interface
  • Adjust createInstances function to fulfill new interface

Notes:

  • previously there is a db attribute that provides access to firestore (which is confused me..)
  • seems that there is confusion with db and database attributes now
  • I guess to have API more consistent, probably better to rename db -> firestore. But it leads to breaking changes Like:
firestore: firebaseAdmin.firestore.Firestore;

WDYT?

faustman avatar May 25 '22 11:05 faustman

thank you pr :) plz review CI results

I guess to have API more consistent, probably better to rename db -> firestore

Good idea, since it is a BREAKING CHANGE, I will do it when I release version 9

9renpoto avatar May 31 '22 13:05 9renpoto

@9renpoto Any update on this ?

shahkeyur avatar Aug 17 '22 18:08 shahkeyur

We are preparing for the release of v9 here. We would be happy to have you test through this PR, but if it seems difficult, we will consider cherry-pick.

9renpoto avatar Aug 22 '22 01:08 9renpoto

Thanks for the update. I can see if I could run some test and let you know.

shahkeyur avatar Aug 22 '22 01:08 shahkeyur