Greg Bowler

Results 120 comments of Greg Bowler

Great! I'll keep the pull request open for a bit longer while I integrate the branch into a few live apps I'm running.

This solution won't work. If static analysis is complaining that there isn't a `href` attribute, it will still complain that there _might not_ be a `href` attribute. Without being specific,...

All phpstan tests are addressed now the facade branch is merged into master, apart from ones regarding generics. I'm having a tough time understanding how to properly use them, but...

I'm going to need some help with this one. See branch [264-phpstan](https://github.com/PhpGt/Dom/tree/264-phpstan) - there are so many errors on phpstan level 6 caused by the use of generics throughout. I...

Yes I am using WSL, but I can use the inbuilt server when using PHP.exe or running PHP in a virtual machine, so I expected the same behaviour through this...

This is possibly due to an open bug with WSL: https://github.com/Microsoft/WSL/issues/1614

Thank you! I'll look into what needs to be changed.

#92 is now merged. Feedback is appreciated.

Example of why this is necessary is for if any WebEngine code throws an exception (for example, if the supplied CSRF token is invalid). It would still be useful to...

This should be possible now the Service Container has moved to lazy initialisation - there doesn't need to be a call to `session_start()` if there is no use of the...