react-tournament-brackets icon indicating copy to clipboard operation
react-tournament-brackets copied to clipboard

Set SVG Height based on max of column lengths.

Open EjPlatzer opened this issue 1 year ago • 1 comments

Currently, the height of the SVG is set based on the length of the first column. This works when the first round of the bracket is completely full. However, if the bracket is sparse (i.e. bye rounds are not shown), then it's possible for the first column to have fewer matches (and therefore be shorter) than later columns.

To fix this, I have updated the calls to calculateSVGDimensions. Before, the numOfRows param was always set to the length of columns[0]. Now, it is set to the maximum length of all columns.

EjPlatzer avatar Jul 12 '24 17:07 EjPlatzer

If you could, please re-open this Pull request in the project's new repository since this repository has no maintainers with access to it anymore more details here https://github.com/g-loot/react-tournament-brackets/issues/78

Shenato avatar Jan 14 '25 20:01 Shenato