flutter_smooth icon indicating copy to clipboard operation
flutter_smooth copied to clipboard

Disable the deliberate delay

Open theniceboy opened this issue 3 years ago • 7 comments

How to disable the deliberate delay mentioned in https://cjycode.com/flutter_smooth/design/infra/gesture/delay ?

Thanks!

theniceboy avatar Oct 28 '22 15:10 theniceboy

Hi! Thanks for opening your first issue here! :smile:

welcome[bot] avatar Oct 28 '22 15:10 welcome[bot]

That probably is more than simply disabling it. Looking at the section of doc, we can see it is there to avoid inconsistency. But I guess it should be able to be disabled. Feel free to PR!

fzyzcjy avatar Oct 28 '22 23:10 fzyzcjy

@theniceboy

Unfortunately I won’t be able to create a PR

Not sure what is happening. do you mean Your github account has some problem?

fzyzcjy avatar Oct 29 '22 03:10 fzyzcjy

@theniceboy Well that is a problem :/ It should be more than a flag to disable it. Indeed, need to consider a bit how the change affects other parts of the system. I have not examined the details yet (quite busy now), but the rough idea looks feasible IMHO.

fzyzcjy avatar Oct 29 '22 04:10 fzyzcjy

Not checked yet, but again you are welcomed to learn more about flutter and check that :)

fzyzcjy avatar Nov 07 '22 04:11 fzyzcjy

To be honest it's not really realistic for a normal developer like me to dig into the Flutter framework.

Don't think it is impossible - every expert in every field must have been a newlearner in the beginning.

As a first step, there are some book chapters discussing flutter internals (since I see you are Chinese, this one looks good: https://book.flutterchina.club/chapter14/flutter_ui_system.html written by @wendux). It is indeed not that hard :)

I will try to find some time to look at it. But as said before, I have my own work to do and need to firstly make the PRs for flutter_smooth.

fzyzcjy avatar Nov 07 '22 05:11 fzyzcjy

I see. But open source is just like this - I do not have infinite time and energy to solve all problems, and since it is open sourced, everyone can freely contribute :)

fzyzcjy avatar Nov 07 '22 05:11 fzyzcjy

But based on the contribution I see on this package... It's gonna be hard.

I agree. But anyway, this package is even not production ready yet - because the flutter PRs have not been merged. So hopefully it will be different in the future.

I do respect your github contribution chart though. You almost have infinite time and energy😄

No that just because I prefer to separate commit into tiny parts (you can see the style from my open source libs).

But yes, I do programming 7 days a week.

fzyzcjy avatar Nov 07 '22 06:11 fzyzcjy

Thanks :)

(Btw please speak english in github since it is read by people in the world)

fzyzcjy avatar Nov 07 '22 06:11 fzyzcjy

actually. . . I don't think it matters. . . Two Chinese people are typing English here, and I still feel a little awkward. (so many grammatical errors 😂)

It is not the problem of you, but instead the problem of the future readers. What do you feel when you go to a github repo and look at an issue that is important to you, only to find someone speaking languages that you have never learnt? :)

And as for grammar errors - IMHO it does not matter as long as everyone can understand the content.

Thank you so much for your contribution to Flutter. I see that your PR has a lot of difficulties. I hope you and the team will have a smooth discussion next time. come on!

You are welcome. Btw it is me (one single individual developer), not a team.

Would you like to add a contact if you don't mind? I didn't find it on your homepage. My email is on my homepage.

You can find me on github as well as Flutter discord :) I reply usually quite quickly.

fzyzcjy avatar Nov 07 '22 06:11 fzyzcjy

不浪费你时间啦,加油加油

theniceboy avatar Nov 07 '22 06:11 theniceboy

Thank you :)

fzyzcjy avatar Nov 07 '22 06:11 fzyzcjy

不用谢~

theniceboy avatar Nov 07 '22 06:11 theniceboy

哦哦你没太理解我的意思😂 我是说加油和Flutter团队交流

theniceboy avatar Nov 07 '22 06:11 theniceboy

I see. Thanks :)

fzyzcjy avatar Nov 07 '22 06:11 fzyzcjy