flutter_rust_bridge
flutter_rust_bridge copied to clipboard
Fixed typo
Changes
Please list issues fixed by this PR here, using format "Fixes #the-issue-number".
Checklist
- [ x] An issue to be fixed by this PR is listed above.
- [ ] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
- [ ]
./frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc). - [ ] If this PR adds/changes features, documentations (in the
./websitefolder) are updated. - [ ] CI is passing. Please refer to this page to see how to solve a failed CI.
Remark for PR creator
Great project, thanks!
./frb_internal --helpshows utilities for development.- If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.
Hi! Thanks for opening this pull request! :smile:
Hi thanks for fixing typos! However, I guess "another" is not very wrong, because I want to say it is one other library. Btw, if you are interested in fixing typos in doc to improve reading, feel free to do so!
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.75%. Comparing base (
0dd3f79) to head (6ef2e43).
Additional details and impacted files
@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
- Coverage 98.92% 97.75% -1.18%
==========================================
Files 493 493
Lines 20347 20328 -19
==========================================
- Hits 20129 19872 -257
- Misses 218 456 +238
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
AI tells me that the old sentence do have a grammar mistake and the new one don't, because "another" can only be a determeter while "other" can be an adjective. And "Here is my other open-source library" do mean "这是我的另一个开源库". But it is so common for non-native English users to make this mistake.😂 I think this PR shall be merged.
Thanks!
Hi! Congrats on merging your first pull request! :tada:
(CI failure is unrelated; I will fix it separately)
@all-contributors please add ernstvanderlinden for doc