Fauzan
Fauzan
I think the subquery mickhansen mentioned [here](https://github.com/sequelize/sequelize/issues/5235#issuecomment-172473451) is to use the `having` query. Correct me if I'm wrong but maybe you can try it first. ```js const result = await...
This is related to how asynchronous works. Do you already try to put `reload` above `update`?
Since we using squash and merge approach, I don't think we really mind about the commit messages, what's better types to use for the PR title? I'm stick with `fix`...
> I would use `meta` since this should not affect other projects using sequelize Thanks for the input :)
> From what I understand based on [this]https://git-scm.com/docs/gitattributes#_end_of_line_conversion), files should still be normalized to lf when pushed. > > Is this an issue though? The only time I had issues...
This PR isn't very useful if developers know to always use LF for the line endings, but if they accidentally use CRLF, it really helps avoid conflicts.
> Yes but that's not the issue, vscode is perfectly able to view & edit files that use LF. Does it cause any issue to windows users to enforce the...
> Anyway, as long as it doesn't cause crlf to be pushed to the repo, I'm fine with it I agree 👍
> Does that mean that we have different like endings in different platforms? Isn't that causing problems? It will always use the default git line endings on checkout and commit...
> > but it will great to avoid CRLF being pushed to the repo. > > I'm confused, isn't that what the current config already does? :o I thought that...