Felipe Zipitría
Felipe Zipitría
Thanks for your contribution @highpingblorg! Writing tests is easy. Maybe taking a quick look at our https://github.com/coreruleset/coreruleset/blob/main/CONTRIBUTING.md, will give you more insights. Here is the Tl; DR version https://github.com/coreruleset/coreruleset/blob/main/CONTRIBUTING.md#writing-tests. See...
Good question. We need to review this...
Added some tests in go-ftw, and looks like [it is doing the encoding](https://github.com/corazawaf/coraza/issues/1193#issuecomment-2492561551)...
> Since this is a big change, I likely may have missed some commands that were intended to be matched (For example, ip matching iptables and ip6tables) but were shortened...
> (?:[\s&|)]|$) Maybe using a word boundary instead? Like `(?:[\s&|)])?\b`.
We are in the process of writing an official document with our release policy.
Yes, removing duplicates makes sense.
What is needed here? Do we merge?
@EsadCetiner Can you fix the conflicts and can we push this one to the end?