Mexico

[mikk150]

implemented basic Mexico

[Faryshta]

what is needed for this to be merged?

[fzaninotto]

Needs rebase

[fzaninotto]

Can you squash your 19 commits into one?

[mikk150]

Yes I could, but you should never rewrite history in git

[Faryshta]

@fzaninotto i think its easier for you to squash them from git merge options.

do you see an 'squash and merge' option at the bottom of this pr?

[mikk150]

https://www.kernel.org/pub/software/scm/git/docs/user-manual.html#problems-With-rewriting-history

[fzaninotto]

Let me put this differently: I don't want to see a merge commit in your PR, because it brings some changes unrelated to your work in the changeset. So what I really want is for you to rebase on master, not merge master in.

[mikk150]

Because rewriting history is great???

I will do it, just know that it is not best thing to do

[fzaninotto]

dude, please don't teach me how to do web development

[mikk150]

I'm not telling you how to do web development I am telling you how you should not do CVS You should not rewrite history on already published branches

[fzaninotto]

tests fail

[fzaninotto]

bump: please fix this PR or I'll close it.

[mikk150]

Maybe you should add some kind of thing to travis, that php-nightly can fail?

Because I get if php5.4 - 7.2 fail, maye even HHVM but you can never be sure what caused the issue with nightly..

Test that failed was not even touched.... soooooooo

[edbentinck]

It'd be great if we could get this merged 👍

[localheinz]

@mikk150

Are you still interested in working on this? If so, we could help you get this through!

[mikk150]

@mikk150

Are you still interestedin working on this? If so, we could help you get this through!

@localheinz I would like to.

[codecov-io]

Codecov Report

Merging #979 into master will increase coverage by 0.54%. The diff coverage is 91.76%.

@@             Coverage Diff              @@
##             master     #979      +/-   ##
============================================
+ Coverage     56.31%   56.86%   +0.54%     
- Complexity     2068     2109      +41     
============================================
  Files           306      308       +2     
  Lines          4851     4936      +85     
============================================
+ Hits           2732     2807      +75     
- Misses         2119     2129      +10     

Impacted Files	Coverage Δ	Complexity Δ
src/Faker/Provider/es_MX/Person.php	91.13% <91.13%> (ø)	39.00 <39.00> (?)
src/Faker/Provider/es_MX/Payment.php	100.00% <100.00%> (ø)	2.00 <2.00> (?)
src/Faker/Provider/de_DE/Person.php	0.00% <0.00%> (-100.00%)	1.00% <0.00%> (ø%)
src/Faker/Provider/he_IL/Address.php	0.00% <0.00%> (-100.00%)	1.00% <0.00%> (ø%)
src/Faker/Provider/ne_NP/Person.php	0.00% <0.00%> (-50.00%)	2.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php	50.00% <0.00%> (-50.00%)	2.00% <0.00%> (ø%)
src/Faker/Provider/en_AU/PhoneNumber.php	0.00% <0.00%> (-50.00%)	2.00% <0.00%> (ø%)
src/Faker/Provider/sr_Latn_RS/Address.php	66.66% <0.00%> (-33.34%)	3.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php	75.00% <0.00%> (-25.00%)	3.00% <0.00%> (ø%)
src/Faker/Provider/es_AR/Address.php	50.00% <0.00%> (-25.00%)	4.00% <0.00%> (ø%)
... and 45 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 468dfa6...5a539f6. Read the comment docs.