Faker icon indicating copy to clipboard operation
Faker copied to clipboard

Typo in function's name

Open carlos-mora opened this issue 4 years ago • 3 comments

There is a typo in the functions's name, it should be tollFreePhoneNumber instead of tollFreeNumber

carlos-mora avatar Jul 16 '20 07:07 carlos-mora

This will be a breaking change!

pimjansen avatar Oct 23 '20 07:10 pimjansen

@pimjansen The breaking change was to accept the spanish module with a bad named function. The interface spects the function to be called tollFreePhoneNumber instead of tollFreeNumber, so in the current state the spanish language is broken. Try it yourself: Use tollFreePhoneNumber in your current language, be sure it works fine, then change to es_ES language. Are you the reviewer to accept the push? An alternative is to duplicate the function with the right name an keep the old bad_named function, but i think the right answer it to set the function name to the spected one.

carlos-mora avatar Oct 23 '20 08:10 carlos-mora

According to the docs, imagen So the function should keep the name accross languages.

carlos-mora avatar Oct 23 '20 08:10 carlos-mora