HypeScript icon indicating copy to clipboard operation
HypeScript copied to clipboard

Published 20 hours ago • verified publisher icon fzakaria

Bad character encoding / special characters omitted

Open jmduke opened this issue 11 years ago • 5 comments

Special characters (eg !@#$%^) seem to be deleted:

BethRest (Solo Piano Version) by Bon Iver

FETCHING SONG....
You  I by Local Natives

jmduke avatar Dec 24 '13 05:12 jmduke

I believe I had trouble with the filenames that were created if they were still there. Filenames are the title tracks at the moment.

the MP3 meta information should be proper hoever?

fzakaria avatar Dec 26 '13 16:12 fzakaria

In those two above cases as well as a few others, the mp3 file didn't actually have any metadata (I'm guessing this is simply because the hosted file didn't?).

There are a few libraries available (eyeD3, mutagen) that can write ID3 tags, though. I'd be more than happy to submit a PR that adds tags for files which don't have them -- what are your thoughts?

jmduke avatar Dec 26 '13 18:12 jmduke

I originally had a bunch of this kind of stuff in the script but I opted to rip it out. I wanted this script to just be a learning example primarily on how to pull data from HypeMachine.

It might do better to refactor it into modules with the basic pullar and people can add additional modules of adding tags.

Farid Zakaria

On Thu, Dec 26, 2013 at 10:12 AM, Justin Duke [email protected]:

In those two above cases as well as a few others, the mp3 file didn't actually have any metadata (I'm guessing this is simply because the hosted file didn't?).

There are a few libraries available (eyeD3, mutagen) that can write ID3 tags, though. I'd be more than happy to submit a PR that adds tags for files which don't have them -- what are your thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/fzakaria/HypeScript/issues/11#issuecomment-31229819 .

fzakaria avatar Dec 26 '13 18:12 fzakaria

Cool, I agree. I'll take a stab at a refactor and submit a PR, if you don't mind.

jmduke avatar Dec 29 '13 23:12 jmduke

Please do! Put it as a separate script maybe and we can keep the simple one also so people can still use it to learn ? On 29 Dec 2013 15:02, "Justin Duke" [email protected] wrote:

Cool, I agree. I'll take a stab at a refactor and submit a PR, if you don't mind.

— Reply to this email directly or view it on GitHubhttps://github.com/fzakaria/HypeScript/issues/11#issuecomment-31327684 .

fzakaria avatar Dec 30 '13 03:12 fzakaria