umar farouk yunusa
umar farouk yunusa
Oh yeah, I'm on it already thanks On Sun, Oct 16, 2022, 9:23 PM Scott Cranfill ***@***.***> wrote: > Hey @fyunusa , no need to ask, just state > that...
Hi @thibaudcolas, @Scotchester, @lb- I've made fixes to the task below but i need clarifications on some of the task on the list which aren't clear. **Fixed** - The "No...
Ok will do so shortly
> @fyunusa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @microsoft-github-policy-service agree [company="{your company}"] >...
> @fyunusa, Thanks for the PR. However, as there are many linter errors: > > https://dev.azure.com/azclitools/public/_build/results?buildId=58123&view=logs&jobId=36dd4138-4d53-5e46-00d9-e5cd9744be05&j=36dd4138-4d53-5e46-00d9-e5cd9744be05&t=1cf3879c-0a42-5ccd-7693-7a4781d739d8 > > ``` > ERROR: ************* Module azure.cli.command_modules.appservice.custom > src/azure-cli/azure/cli/command_modules/appservice/custom.py:2798:0: C0303: Trailing whitespace (trailing-whitespace)...
> > @fyunusa, Thanks for the PR. However, as there are many linter errors: > > https://dev.azure.com/azclitools/public/_build/results?buildId=58123&view=logs&jobId=36dd4138-4d53-5e46-00d9-e5cd9744be05&j=36dd4138-4d53-5e46-00d9-e5cd9744be05&t=1cf3879c-0a42-5ccd-7693-7a4781d739d8 > > ``` > > ERROR: ************* Module azure.cli.command_modules.appservice.custom > > src/azure-cli/azure/cli/command_modules/appservice/custom.py:2798:0: C0303:...
> @fyunusa, there are still linter errors. Could you revert `src/azure-cli/azure/cli/command_modules/appservice/custom.py` and `src/azure-cli/azure/cli/command_modules/appservice/tunnel.py` to their original versions? > > I will handle them in https://github.com/Azure/azure-cli/pull/26538. > Ok
> @fyunusa, could you please make the change to let the CI pass? Thanks a lot. > Ok, will work on it as soon
> @fyunusa, could you please make the change to let the CI pass? Thanks a lot. You can check now, so i've updated the tunnel.py & custom.py file to match...
@jiasli i think all checks passed now, so you can review the PR and let me know if my attention is needed