fyne icon indicating copy to clipboard operation
fyne copied to clipboard

widget.Table: show first row/column when navigating with keyboard

Open pierrec opened this issue 1 year ago • 2 comments

Fixes #5088.

Description:

When a Table has its header(s) shown, keyboard navigation fails to show the first row or column if the list was scrolled. This is because the header size is always added to the offset even when the first row/column is reached. Disabling this for the first row or column fixes the issue.

Fixes #5088

Checklist:

  • [X] Tests included.
  • [X] Lint and formatter run with no errors.
  • [X] Tests all pass.

pierrec avatar Sep 08 '24 13:09 pierrec

I tested by moving too fast, I see the issue now. Will get back to it.

pierrec avatar Sep 08 '24 17:09 pierrec

@pierrec can you look at these failures? Because of the force-push it has lost the build history so it is not possible to see where it broke. Please do avoid force-push after reviews have started so we get more info on what is changing.

andydotxyz avatar Oct 16 '24 20:10 andydotxyz

@andydotxyz closing this PR and resubmitting on lastest develop branch.

pierrec avatar Dec 12 '24 19:12 pierrec