fyne icon indicating copy to clipboard operation
fyne copied to clipboard

Published 20 hours ago • verified publisher icon fyne-io

Add IME support

Open kanryu opened this issue 1 year ago • 7 comments

Description:

As everyone knows, fyne does not currently support IME. This is fundamentally caused by the fact that glfw does not support IME, and cannot be resolved by fyne's efforts alone. So I solved this problem by adding a hack to both go-gl/glfw and fyne. Please check it on your PC.

Fixes #618

Supported environments

  • supported
    • Windows
    • Mac
    • Linux(X11, Wayland)
  • not supported
    • Android
    • iOS

How to try this

git clone https://github.com/kanryu/fyne
git clone https://github.com/kanryu/glfw
cd fyne
go mod edit -replace github.com/go-gl/glfw/v3.3/glfw=../glfw/v3.4/glfw
go run cmd/fyne_demo/main.go

https://github.com/fyne-io/fyne/assets/759165/89c858dc-beaf-4b19-948f-77baee4aa2a6

Checklist:

  • [ ] Tests included.
  • [ ] Lint and formatter run with no errors.
  • [ ] Tests all pass.

Where applicable:

  • [ ] Public APIs match existing style and have Since: line.
  • [ ] Any breaking changes have a deprecation path or have been discussed.
  • [ ] Check for binary size increases when importing new modules.

kanryu avatar Feb 06 '24 11:02 kanryu

スクリーンショット 2024-02-14 11 36 16 Full input is now available on Mac.

kanryu avatar Feb 14 '24 02:02 kanryu

image

I cloned the latest branch and run the demo, the entry's 'select all' focus effect is confusing.

qizhanchan avatar Apr 06 '24 04:04 qizhanchan

@kanryu If you are experiencing a bug on develop, report it as an issue instead of as a comment on a PR please. Thanks.

Jacalz avatar Apr 06 '24 09:04 Jacalz

I cloned the latest branch and run the demo, the entry's 'select all' focus effect is confusing.

@qizhanchan This issue is not caused by this PR's fix, but also occurs with the original Fyne Entry. So it's a Fyne problem.

kanryu avatar Apr 06 '24 15:04 kanryu

If you are experiencing a bug on develop, report it as an issue instead of as a comment on a PR please. Thanks.

@Jacalz Which problem in this PR are you pointing out? This PR involves a very large source code modification.

kanryu avatar Apr 06 '24 15:04 kanryu

Ah, sorry @kanryu. I meant to be tagging @qizhanchan in my message. I assumed that he was referring to a bug on the develop branch.

Jacalz avatar Apr 06 '24 15:04 Jacalz

Converting to draft as this is not in a state where we would be reviewing for merge.

andydotxyz avatar Apr 23 '24 14:04 andydotxyz