fyne-x
fyne-x copied to clipboard
Added date_input_widget
Can you please stick to one item per PR? I don’t we should land separate widgets and layouts within the same PR.
Is the HBox layout not kind of a duplicate of https://github.com/fyne-io/fyne-x/pull/64?
I wanted to layout widget horizontally and can't find any other layout if it is same then reject it. One difference is this layout only expand horizontally.
I will stick to one item per PR for now on.
In that case, can you please update the PR (or open a new one id you prefer) that only includes one of the features?
I do think that the layout in question indeed is mostly the same as the one linked above. I'll try it complete that PR some time in the future. The full list of layouts in Fyne can be found here: https://developer.fyne.io/explore/layouts
okay let me just add the date input widget
I have remove the layout code.
Thanks. I'll try to review the code some day going forward
I just came back to this (sorry for the delay) and notice that MyDateEntry
is still a fairly strange name ;).
Also if you can rebase onto latest main
the tests should all pass again.
I just came back to this (sorry for the delay) and notice that
MyDateEntry
is still a fairly strange name ;). Also if you can rebase onto latestmain
the tests should all pass again.
I have rewrite the whole widget this time using /richtext : https://github.com/heejit/fyne_codes/blob/main/widget_date_input.go
I just wanted to see the status of this and tried to resolve the conflict but as it was a PR from your master branch GitHub warned me not to, so I didn't - but it's a simple change.
I am sorry it took so long to get back to this - I hadn't noticed that there were commits since the last feedback. However the naming is still not resolved as requested by Jacalz and there are references to your fork in the README.
Also it seems like you're looking to behave like an Entry but it isn't an Entry - so why not just extend Entry?
I have been working on an alternative picker based on the Calendar
here and a simple Entry widget with an accessory for popping up the calendar, changes to the Entry theming made this fairly simple - not sure if this changes your thoughts?