fyne-x icon indicating copy to clipboard operation
fyne-x copied to clipboard

Added date_input_widget

Open heejit opened this issue 1 year ago • 9 comments

heejit avatar Jun 25 '23 15:06 heejit

Can you please stick to one item per PR? I don’t we should land separate widgets and layouts within the same PR.

Is the HBox layout not kind of a duplicate of https://github.com/fyne-io/fyne-x/pull/64?

Jacalz avatar Jun 25 '23 16:06 Jacalz

I wanted to layout widget horizontally and can't find any other layout if it is same then reject it. One difference is this layout only expand horizontally.

heejit avatar Jun 25 '23 17:06 heejit

I will stick to one item per PR for now on.

heejit avatar Jun 25 '23 17:06 heejit

In that case, can you please update the PR (or open a new one id you prefer) that only includes one of the features?

I do think that the layout in question indeed is mostly the same as the one linked above. I'll try it complete that PR some time in the future. The full list of layouts in Fyne can be found here: https://developer.fyne.io/explore/layouts

Jacalz avatar Jun 25 '23 18:06 Jacalz

okay let me just add the date input widget

heejit avatar Jun 25 '23 18:06 heejit

I have remove the layout code.

heejit avatar Jun 25 '23 18:06 heejit

Thanks. I'll try to review the code some day going forward

Jacalz avatar Jun 25 '23 19:06 Jacalz

I just came back to this (sorry for the delay) and notice that MyDateEntry is still a fairly strange name ;). Also if you can rebase onto latest main the tests should all pass again.

andydotxyz avatar Oct 04 '23 12:10 andydotxyz

I just came back to this (sorry for the delay) and notice that MyDateEntry is still a fairly strange name ;). Also if you can rebase onto latest main the tests should all pass again.

I have rewrite the whole widget this time using /richtext : https://github.com/heejit/fyne_codes/blob/main/widget_date_input.go

heejit avatar Oct 05 '23 06:10 heejit

I just wanted to see the status of this and tried to resolve the conflict but as it was a PR from your master branch GitHub warned me not to, so I didn't - but it's a simple change.

I am sorry it took so long to get back to this - I hadn't noticed that there were commits since the last feedback. However the naming is still not resolved as requested by Jacalz and there are references to your fork in the README.

Also it seems like you're looking to behave like an Entry but it isn't an Entry - so why not just extend Entry? I have been working on an alternative picker based on the Calendar here and a simple Entry widget with an accessory for popping up the calendar, changes to the Entry theming made this fairly simple - not sure if this changes your thoughts?

Screenshot 2024-09-07 at 18 30 15

andydotxyz avatar Sep 07 '24 17:09 andydotxyz