Sample-Portfolio-for-Learners icon indicating copy to clipboard operation
Sample-Portfolio-for-Learners copied to clipboard

Published 20 hours ago • verified publisher icon fykaa

Adding footer to learning page

Open komalioruganti opened this issue 2 years ago • 7 comments

There is no footer for the learnings page. Can u assign me this issue?

komalioruganti avatar Oct 14 '22 14:10 komalioruganti

Hey @fykaa . I would like to work on this issue. Can you assign me this? Also it would be great if you could add a hacktoberfest tag to this issue

komalioruganti avatar Oct 16 '22 02:10 komalioruganti

Hey! I made these changes. Can I make a PR now?

BEFORE:

image

AFTER:

image

komalioruganti avatar Oct 17 '22 11:10 komalioruganti

hey can you assign it to me , i will make it more beutifull

unovajnv avatar Oct 20 '22 05:10 unovajnv

Sure @unovajnv

fykaa avatar Oct 20 '22 07:10 fykaa

What do you think about this?

image

komalioruganti avatar Oct 21 '22 08:10 komalioruganti

Hi, @komalioruganti Your PR has merge conflicts, Can you please look into it. Thanks :) #79

fykaa avatar Oct 21 '22 08:10 fykaa

Yeah sure. I actually made a new PR. Can you review it and let me know if there are any more conflicts? I will resolve them.

komalioruganti avatar Oct 21 '22 11:10 komalioruganti