Aleš

Results 99 comments of Aleš

Upon further testing, nothing inside `ObservableEvent` is at fault. Even if it was empty inside, it still breaks that ngOnDestroy in aot. So it's whatever happen on build / with...

Yeah, so `hasLifecycleHook` assumes that `ngOnDestroy` is on the class itself, doesn't account for the possibility of it being defined in a class the class extends from, thus overriding it....

I think that [this](https://github.com/typebytes/ngx-template-streams/blob/master/projects/ngx-template-streams/src/internal/transformers/add-lifecycle-hooks.ts#L79) or rather the [query](https://github.com/typebytes/ngx-template-streams/blob/master/projects/ngx-template-streams/src/internal/transformers/queries.ts#L26) it calls needs to do this https://github.com/phenomnomnominal/tsquery/issues/30 but I haven't really figured out how to even debug this.

What's the dev flow like? Do I run `test:debug`, put some breakpoints in and use remote dev tools?

Could it possibly be done using some sort of configuration? User would list which base classes implement ngOnDestroy, use that in the `getLifecycleQuery` query. I imagine only few classes in...

yeah I guess, you could use import alias to rename existing classes

but configuration still sounds better.. or make it possible both ways