web-mode icon indicating copy to clipboard operation
web-mode copied to clipboard

[WIP] Add class and tag faces

Open minikN opened this issue 4 years ago • 3 comments

Hello, I've added two new faces: web-mode-css-selector-class-face and web-mode-css-selector-tag-face.

I'd like to enhance web-mode's css highlighting abilities, eventually being able to highlight syntax like so:

image

At the moment I just added the ability to differenciate between class selectors (.myclass { ...}) and tag selectors (div {...}).

Ideally I would add some more rules, and I'm sure what I already added could be improved, it's not perfect yet but a proof of concept. Before continuing working on this however, I'd like to know if a change like this is welcomed and whether or not I should keep going with this.

Cheers.

minikN avatar Mar 18 '20 15:03 minikN

LGTM :smile:

black7375 avatar Mar 19 '20 22:03 black7375

What does @fxbois think?

minikN avatar Mar 21 '20 11:03 minikN

@minikN good idea

fxbois avatar Apr 03 '20 15:04 fxbois

thx

fxbois avatar Aug 19 '22 09:08 fxbois