fwupd icon indicating copy to clipboard operation
fwupd copied to clipboard

Support asmedia usb4 format

Open superm1 opened this issue 3 years ago • 3 comments

There are patches on the mailing list that will be adding support for the NVM format used by ASMedia. We should make sure that the matching code for fwupd is also updated for this.

https://lore.kernel.org/linux-usb/[email protected]/

superm1 avatar Aug 08 '22 12:08 superm1

Got a hint? Would this be a variant of libfwupdplugin/fu-intel-nvm.c as added in wip/hughsie/FuIntelNvm?

hughsie avatar Aug 10 '22 12:08 hughsie

Yeah it should definitely come with or after that.

I was just raising it now in case it makes sense to fold into the same branch.

superm1 avatar Aug 10 '22 13:08 superm1

variant of libfwupdplugin/fu-intel-nvm.c

I haven't looked closely; but I don't have any expectation that it shares same characteristics as this. It should be "another" kind of NVM, not subclass that.

superm1 avatar Aug 10 '22 13:08 superm1

They submitted a v3, here's the updated link for it: https://lore.kernel.org/linux-usb/[email protected]/T/#m1a8b1478fad56317e8f2c0895e996876a3aafca4

I left some comments with the goal that they can re-use the existing sysfs files so userspace doesn't need to change how the version string parses significantly. Depending on what is accepted we will want to at least update our unit tests.

superm1 avatar Aug 15 '22 17:08 superm1

With the changes in 1.8.5 I suspect this is no work unless we get more details from ASMedia, so I'm going to close it. If we to end up needing changes will revisit then.

superm1 avatar Aug 31 '22 20:08 superm1