firmware-dell icon indicating copy to clipboard operation
firmware-dell copied to clipboard

Please add individual model number(s) when using the "X" placeholder in generic names

Open pjwelsh opened this issue 3 years ago • 6 comments

Searching for specific model number when grouped with an "X" placeholder does not seem to provide good search capability. Please the specific model number that are included. Example searches: latitude 5590 != latitude 5X90 https://fwupd.org/lvfs/search?value=latitude+5X90 produces BIOS results https://fwupd.org/lvfs/search?value=latitude+5590 produces no results

latitude 5580 != latitude 5X80 https://fwupd.org/lvfs/search?value=latitude+5X80 produces BIOS results https://fwupd.org/lvfs/search?value=latitude+5580 produces Thunderbolt updates (not BIOS)

latitude 7480 != latitude 7X80 https://fwupd.org/lvfs/search?value=latitude+7X80 produces BIOS results https://fwupd.org/lvfs/search?value=latitude+7480 produces Thunderbolt updates (not BIOS)

pjwelsh avatar Oct 11 '21 17:10 pjwelsh

Is X always a wildcard? I think we ought to just include the specific model numbers as search tokens. Not sure how to automate that..

hughsie avatar Oct 11 '21 17:10 hughsie

The "X" is not a "wildcard", it is part of the required search string in order to find the BIOS link. And yes, the specific model number should at least added to the generic name reference (or the search expanded to something that includes those).

pjwelsh avatar Oct 11 '21 17:10 pjwelsh

The "X" seems to happen only with some of the laptops groups, but not all (based on shared platform no doubt).

pjwelsh avatar Oct 11 '21 17:10 pjwelsh

Just a nudge to consider more easily searchable names.

pjwelsh avatar Feb 20 '22 16:02 pjwelsh

Any more thoughts on adding the meta-search for shared platform entries? Current example is for a Dell Latitude 3490: Searching for "Latitude 3490" will not produce any results via the search bar. However, it is there as just the "3x90".

pjwelsh avatar May 19 '22 11:05 pjwelsh

Here are the current Dell units that we have that fall under this category noted from my scripting: #next needed because of inconsistent naming/usage of 3040m -vs 3040 #next needed because of inconsistent naming/usage of 7480 -vs 7X80 #next needed because of inconsistent naming/usage of t3620 -vs 3620 #next needed because of inconsistent naming/usage of 5580 -vs 5X80 #next needed because of inconsistent naming/usage of 3490 and 3590 -vs 3X90 #next needed because of inconsistent naming/usage of 5590 -vs 5X90 The inconsistent naming is between what dell.com support site has and what lvfs search has.

pjwelsh avatar May 19 '22 11:05 pjwelsh