Friso Smit
Friso Smit
Okay, I'll reopen it :)
Maybe it's better to set the timeout id to zero when it's removed
What is difficult about the test binary? It just needs to be compiled and run with valgrind. Meson probably has some way to run binaries
Yeah, seems good to me. Maybe @bebehei has a stronger opinion about this, since he set up most of our testing infrastructure.
The changes look good overall. I've left one comment. Does @bebehei have any last comments? > unfortunately, i'm not really that great at writing this new change in the CHANGELOG...
It seems the tests don't run. At least in the github tests it says the following 0s Run ninja -C build test ninja: Entering directory `build' [0/1] Running all tests....
> And for your idea to keep it simple and don't add to much now. I know that it makes sense to do so. However I think that if we...
Please add some tests as well. Our dbus interface is currently very well tested
These shell completions look very promising. There's so many exciting things you can do with it :smile:
Let me know if you'd like me to give it another round of review