point-cloud-utils icon indicating copy to clipboard operation
point-cloud-utils copied to clipboard

Adds MANIFEST.in

Open cosama opened this issue 5 months ago • 2 comments

This fixes the sdist release; Currently, the tar.gz do not contain all the necessary build files (C, cmake, etc) and it is not possible to install through pypi from source. Adding the MANIFEST.in will fix that.

I had a minute and just went ahead and looked into this. It seems you need a MANIFEST.in. I modeled one, mostly based on your .gitignore (for excludes) and included the src, external, cmake and tests directories. It also keeps the release tar.gz quite small at ~350kB. I think this works, running the build right now to make sure of it.

Closes https://github.com/fwilliams/point-cloud-utils/issues/92

cosama avatar Jul 18 '25 06:07 cosama

Builds just fine but I get this:

Python 3.12.3 (main, Feb  4 2025, 14:48:35) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import point_cloud_utils
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "point-cloud-utils/point_cloud_utils/__init__.py", line 4, in <module>
    from ._pcu_internal import sample_mesh_poisson_disk, sample_mesh_random, \
ModuleNotFoundError: No module named 'point_cloud_utils._pcu_internal'

Probably because I excluded the *.so in the manifest.

cosama avatar Jul 18 '25 15:07 cosama

I was wrong, I ran the import in the root folder of the repo and that messed it up. This actually works. I forgot to exclude a few directories though. I fixed this now.

@JacksonFurrier This should fix #92 if it is merged.

I think this is ready.

cosama avatar Jul 19 '25 17:07 cosama