fml icon indicating copy to clipboard operation
fml copied to clipboard

update logsumexp

Open edgarriba opened this issue 5 years ago • 1 comments

hi @fwilliams,

in recent pytorch versions it has been introduced torch.logsumexp which I think that could be used to replace stabilized_log_sum_exp in your implementation of the sinkhorn algorithm.

found this throw: https://github.com/magicleap/SuperGluePretrainedNetwork/blob/master/models/superglue.py#L143-L172

edgarriba avatar Mar 30 '20 11:03 edgarriba

Thanks for the pointer! I wrote this during a project in 2018 and didn't know this function was available. I'll update this in the next version of the library.

fwilliams avatar Mar 30 '20 16:03 fwilliams