QuicKey icon indicating copy to clipboard operation
QuicKey copied to clipboard

When target Tab cannot be found, related history or bookmarks should be displayed by default.

Open zgqq opened this issue 4 years ago • 5 comments

It's hard to know if the page you want to open is already open. Thank you for making such a nice extension.

zgqq avatar Sep 09 '19 07:09 zgqq

Any reason you closed this? It's a reasonable enhancement request. The history and bookmarks aren't loaded when the menu first appears because it would cause a noticeable delay. But maybe if the results list got below 5 (?) items it could try a match against history and bookmarks.

fwextensions avatar Sep 09 '19 17:09 fwextensions

@fwextensions Because when I searched for a Tab that didn't exist, it looked like there were some item results. Therefore, I thought this feature had been implemented.

zgqq avatar Sep 10 '19 18:09 zgqq

If this does get implemented, then please also bear in mind the processing costs of loading and searching through bookmarks and history entries that can potentially number into the thousands.

QuickTabs (the other similar extension) causes a Chrome freeze at startup on my main Google account. I'm not sure whether the number of bookmarks is why, but it seems a reasonable possibility.

The entire reason I (and I assume many others) use QuicKey is for its snappiness, so I'd suggest it might be more important to preserve speed than to add a feature which would be somewhat redundant to native Chromium functionality, if those two objectives should end up in conflict.

https://github.com/babyman/quick-tabs-chrome-extension/issues/282

will-ca avatar May 29 '20 20:05 will-ca

Thanks @will-ca , glad you're finding QuicKey speedy. I've definitely worked to keep it that way, and responsiveness will continue to be a goal.

Currently, QuicKey only loads history and bookmark items if you type /h or /b. On my machine, loading 2000 history items takes ~100ms, and 1500 bookmarks takes ~20ms. Even 10X the bookmarks would produce only a slight delay, so I'm not sure what's happening on launch with Quick Tabs.

I'm currently working on a branch where QuicKey appears almost instantaneously, using an option that renders it in a popup window instead of the toolbar drop-down. The window gets moved off-screen when you pick a tab, and back on-screen the next time you invoke it, so it doesn't need to re-render. It also has the advantage of letting you use the same shortcut to move the selection in the list, just like alt-tab.

fwextensions avatar Jun 02 '20 02:06 fwextensions

In my opinion, It will be a great feature. I always search without any prefix and then with /h or /b. If someone has a performance issue you would add an option to turn it on/off in the configuration pane. I think it solves the problem. Or (even better) you would add a different shortcut "Search Everywhere". Everyone will use whatever they want to.

plenartowicz avatar May 27 '22 09:05 plenartowicz