tree-sitter-kotlin icon indicating copy to clipboard operation
tree-sitter-kotlin copied to clipboard

refactor(scanner): code cleanup

Open ObserverOfTime opened this issue 1 year ago • 2 comments

  • Use local import for parser.h
  • Use the new built-in array API
  • Define DELIMITER_LENGTH constant
  • Mark simple functions as inline
  • Remove functions that are only used once
  • Remove rarely used mark_end function
  • Simplify scan_whitespace_and_comments function
  • Use bitwise and instead of modulo
  • Various codestyle improvements

ObserverOfTime avatar Mar 13 '24 09:03 ObserverOfTime

Hello? :)

ObserverOfTime avatar May 10 '24 15:05 ObserverOfTime

This looks good to me, but I'd prefer @fwcd to merge this. In the meanwhile can you please rebase on master there are a bunch of things changed and versions upgraded since you original sent this PR

VladimirMakaev avatar May 11 '24 18:05 VladimirMakaev

Thanks!

fwcd avatar Jul 29 '24 15:07 fwcd