tree-sitter-kotlin icon indicating copy to clipboard operation
tree-sitter-kotlin copied to clipboard

Supporting functional interfaces

Open bricka opened this issue 2 years ago • 5 comments

https://kotlinlang.org/docs/fun-interfaces.html

Closes #87

bricka avatar Oct 10 '23 13:10 bricka

@bricka Can you please rebase your fix and regenerate the parser?

VladimirMakaev avatar Oct 24 '23 22:10 VladimirMakaev

@VladimirMakaev Rebased and regenerated :)

bricka avatar Oct 25 '23 07:10 bricka

Hrm...I just tried redoing the tree-sitter generate, but my local one shows no changes to parser.c. Any ideas what could be causing the failed check?

bricka avatar Oct 26 '23 09:10 bricka

Can it be due to this https://github.com/fwcd/tree-sitter-kotlin/issues/92?

VladimirMakaev avatar Nov 06 '23 11:11 VladimirMakaev

I tried to re-generate inside the node:18 image, but that didn't seem to fix the problem for me :(

bricka avatar Jan 16 '24 09:01 bricka

I think my last attempt was on my Mac laptop, but I've just made a change from my Linux laptop. Let's see if that makes the parser generation work correctly.

bricka avatar Apr 19 '24 08:04 bricka

I'm going to revert this for now since it broke the build

VladimirMakaev avatar May 05 '24 00:05 VladimirMakaev

@VladimirMakaev Hi Vladimir. Did it break because of the generated parser?

If so, how can we push this forward? Could someone who can generate the parser correctly check out this branch, generate the parser, and then push that?

bricka avatar May 24 '24 13:05 bricka

Not sure if you can see the job below, but seems like the generated parser issue

https://github.com/fwcd/tree-sitter-kotlin/actions/runs/8954309216/job/24593808540

I don't have any more context on this beyond https://github.com/fwcd/tree-sitter-kotlin/issues/92

VladimirMakaev avatar May 24 '24 18:05 VladimirMakaev