PartitionedArrays.jl icon indicating copy to clipboard operation
PartitionedArrays.jl copied to clipboard

Diagnostic context missing in some error messages

Open termi-official opened this issue 3 years ago • 3 comments

Some of the error messages could be more helpful if the provide some context about what exactly has been detected.

For example "The sparsity pattern of the ghost layer is inconsistent" could dump some information about where the detected inconsistency is. E.g. something like "The sparsity pattern of the ghost layer is inconsistent on rank $rank at local index ($i,$j)". I understand that it is impossible to reconstruct the full context of the error, especially in an distributed environment, but having at least some information can be immensely helpful when dealing with errors in non-trivial corner cases.

termi-official avatar Jul 20 '22 13:07 termi-official

Hi @termi-official, feel free to enhance this. It should not be very challenging.

fverdugo avatar Jul 20 '22 14:07 fverdugo

Sure, I will propose a PR. Could you just quickly help me with the abbreviations, since I am note very confident what they exactly mean?

gid = ghost id lid = local id hid = ? oid = ?

termi-official avatar Jul 20 '22 14:07 termi-official

Global, Local, gHost, Own. 😀

fverdugo avatar Jul 20 '22 15:07 fverdugo