Federico Valeri
Federico Valeri
> To make the `replicationThrottle` from `KafkaRebalance` work by default, `IGNORED_TOPIC_CONFIG` would need to be `follower.replication.throttled.replicas,leader.replication.throttled.replicas` Yes, but only if CC integration is enabled. https://github.com/strimzi/strimzi-kafka-operator/blob/main/topic-operator/src/main/java/io/strimzi/operator/topic/TopicOperatorConfig.java#L137
Hi @john-mcpeek, do you have time to complete this one? There are few outstanding comments and some conflicts to address. Let us know if you need help.
> Now that `SASL_CUSTOM_CONFIG_JSON` is mutually exclusive with the normal SASL config, what do you all think of using that to skip the `getClusterConfig()` call in `BatchingTopicController` constructor and `warnTooLargeMinIsr()`?...
> Replication factor change not supported, but required for partitions This means that KafkaTopic named my-topic is not aligned with my-topic topic in Kafka in terms of replicas (.spec.replicas !=...
> I could use some help in figuring out how to test the new `STRIMZI_ALTERABLE_TOPIC_CONFIG` property. Any suggestions on where is a good example test to start with? In `BatchingTopicControllerTest`,...
Hi @john-mcpeek, so we have `STRIMZI_ALTERABLE_TOPIC_CONFIG` and related test left. There is no rush, but let me know if you are stuck with something.
> I think there is a fundamental difference here. Ok, I see what you mean now. So we don't even need the "all" change. Will have another pass tomorrow. Thanks.
Hi @john-mcpeek, let's try to find a solution together. Reporting the state of the application in a declarative way is a fundamental part of the operator pattern. If some user...
> The reason I put the alterable property in was that it reports that topic as not ready when it is. This is b/c the operator doesn't "understand" the limitations...
It turns out that null and empty string are equivalent when dealing with env vars, so it's a bit more complicated. If you set `STRIMZI_ALTERABLE_TOPIC_CONFIG` to empty string, then the...