Fuxing Loh

Results 148 comments of Fuxing Loh

/area apps /apps whale-api MasternodeIndexer on `whale-api` isn't configured to handle TestNet Chainparams. We should account for that. /triage accepted

> @canonbrother gave me this. > > ``` > const txn = await this.client.rawtx.getRawTransaction(txid, true) > ``` > > https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts#L328 > > > [rawtx.ts](https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts) Yes, but it's too expensive to...

> 1. If I were to write a unit test, how should it look like? Is there any other test I can refer to? > 2. Should the test be...

Hey, thanks for opening #407 and #393. I will review, add tests and merge this in soon. Just to let you know the direction of this project, we are building...

We're finishing up https://github.com/JellyfishSDK/jellyfish/issues/580 This PR needs to be migrated to https://github.com/JellyfishSDK/jellyfish/tree/main/apps/whale-api

We don't need to manually calculate it anymore since `listpoolpairs` exposes it via `rewardLoanPct` and we can just expose that now.