alcor icon indicating copy to clipboard operation
alcor copied to clipboard
verified publisher icon futurewei-cloud

[RM] getSubnetRouteTable in RouterServiceImpl.java should separate Neutron and VPC router scenario.

Open cj-chung opened this issue 4 years ago • 3 comments

Issue: getSubnetRouteTable in RouterServiceImpl.java is used by both Neutron and VPC scenarios, but it's only deal with VPC scenario in the code.

Suggestion: Add a flag as an input argument in getSubnetRouteTable to indicate the caller's scenario (Neutron or VPC).

cj-chung avatar Jun 23 '21 16:06 cj-chung

@DavidLiu506 Could you also take on this fix as well as Issue #646? Thanks.

xieus avatar Jun 23 '21 20:06 xieus

@kevin-zhonghao Can you also take a look at this issue? Thanks!

xieus avatar Jun 30 '21 03:06 xieus

@kevin-zhonghao Can you also take a look at this issue? Thanks!

Sure, fix in PR#657

kevin-zhonghao avatar Jun 30 '21 03:06 kevin-zhonghao