alcor icon indicating copy to clipboard operation
alcor copied to clipboard

DPM should consume the port in the contract

Open haboy52581 opened this issue 5 years ago • 6 comments

Current implementation DPM doesn't consume this port for now and make the default value 50001 as ACA's port. We need to

  1. Update DPM contract to include this field
  2. DPM implementation and test update.

haboy52581 avatar Jul 27 '20 19:07 haboy52581

this one would be done when contract change in future and port manager should provide this in the contract as well

haboy52581 avatar Aug 09 '20 18:08 haboy52581

Hey @haboy52581 How is this issue? If it has been resolved by previous PR, can you link the PR here? Thanks.

xieus avatar Oct 13 '20 04:10 xieus

This is the server port defined in NodeInfo. In the future, DPM could communicate with Node Metadata Manager to cache the node info so that DPM could find the target gRPC port from its own memory quickly.

{
  "nodeInfos": [
    {
      "node_id": "9192a4d4-ffff-4ece-b3f0-8d36e3d85002",
      "node_name": "node2",
      "local_ip": "10.213.43.161",
      "mac_address": "90:17:ac:c1:34:64",
      "veth": "eth0",
      "server_port": 50001
    }
  ]
}

xieus avatar Oct 16 '20 21:10 xieus

DPM not supposed to talk but ok to cache data

haboy52581 avatar Oct 17 '20 17:10 haboy52581

Current implementation DPM doesn't consume this port for now and make the default value 50001 as ACA's port. We need to

  1. Update DPM contract to include this field
  2. DPM implementation and test update.

@haboy52581 In short-term, we can use existing channels by asking PM to pass down the ACA gRPC port. Do we still update the DPM contract to do that, or it is already updated?

xieus avatar Oct 17 '20 17:10 xieus

the current dpm contract does not contain port info and this is in the configuration of dpm, if you want we could add them then change pm

haboy52581 avatar Oct 26 '20 06:10 haboy52581