InAppSettingsKit icon indicating copy to clipboard operation
InAppSettingsKit copied to clipboard

IASKAppSettingsViewController delegate is unsafely retained

Open via-guy opened this issue 5 months ago • 0 comments

In line 227 of IASKAppSettingsViewController.h we have the following declaration:

@property (nonatomic, assign) IBOutlet id<IASKSettingsDelegate> delegate;

This causes the delegate reference to be unowned, which can lead to a crash when the view disappears. It should be changed to weak.

Screenshot 2024-09-18 at 11 46 19

via-guy avatar Sep 18 '24 09:09 via-guy