epub.js icon indicating copy to clipboard operation
epub.js copied to clipboard

issues with continuous scroll up side doesn't work properly. return to the same page.

Open robiulhassanshakil opened this issue 3 years ago • 8 comments

robiulhassanshakil avatar Oct 17 '22 05:10 robiulhassanshakil

test

robiulhassanshakil avatar Oct 17 '22 05:10 robiulhassanshakil

Is there any solution?

oguzhandurmaz avatar Nov 14 '22 07:11 oguzhandurmaz

Is there any solution?

I did not find any solution right now.

robiulhassanshakil avatar Nov 14 '22 15:11 robiulhassanshakil

I tested continuous scrolling using continuous-scrolled.html from the examples, with jszip added and an epub loaded. The default Moby-Dick opf does not suffer from this issue. I found on Chrome and Firefox (Left Side), the bug is present. On the right side is Gnome Web which is using webkit and it does not suffer from the issue.

bug.webm

btpf avatar Nov 29 '22 16:11 btpf

Hello, there is an error. @btpf

eror.webm

FatmaKaya avatar Nov 30 '22 08:11 FatmaKaya

For me it seems to solve the problem on Android and iOS (Chrome on Android and iOS webview on iOS, I think iOS webview is actually webkit but I am not sure).

-- Ori Idan CEO Helicon Books http://www.heliconbooks.com

On Wed, Nov 30, 2022 at 10:40 AM Fatma KAYA @.***> wrote:

Hello, there is an error. @btpf https://github.com/btpf

eror.webm https://user-images.githubusercontent.com/28539700/204748009-24ec89cc-6443-4d64-9d0d-c5c7099762bd.webm

— Reply to this email directly, view it on GitHub https://github.com/futurepress/epub.js/issues/1295#issuecomment-1331811868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB43QFYT7P4DLASYYX4EHTWK4HG3ANCNFSM6AAAAAARGWNIMU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

OriKuttner avatar Nov 30 '22 10:11 OriKuttner

Hello, there is an error. @btpf

eror.webm

I think this bug occurs when there is an image and you resize. It is also present in webkit. Unfortunately I don't understand the codebase enough to fix. It seems to me that sections stop being appended after resize. The issue may lie in this function. https://github.com/futurepress/epub.js/blob/585bce16a4ce4d013c3a2de795f6d151c2a32f12/src/managers/continuous/index.js#L242

btpf avatar Nov 30 '22 15:11 btpf

Hey @FatmaKaya ,

I noticed that EpubJS's Queue was getting stuck and saw that the check function, enqueued on scroll, was stalling. Binding this function seems to fix the problem!

See: https://github.com/futurepress/epub.js/pull/1305/commits/b6ccddec3764b4068922d0020d34bf0d7f00f243

btpf avatar Feb 17 '23 19:02 btpf