epub.js icon indicating copy to clipboard operation
epub.js copied to clipboard

Viewer should use full screen

Open mariusa opened this issue 4 years ago • 1 comments

In README and at http://futurepress.github.io/epub.js/examples/scrolled.html viewer is hardcoded to specific height/width. These should be left out, so that Viewer takes whole page.

Are height/width required? If so, set the to browser's dimensions.

Examples should work by default on any device size. No need to be responsive, just get dimensions from initial load.

mariusa avatar Nov 12 '21 22:11 mariusa

I think examples should show that it can work with limits and work on all screen sizes, so there should be an example with width and height set to 100%.

-- Ori Idan CEO Helicon Books http://www.heliconbooks.com

On Sat, Nov 13, 2021 at 12:50 AM Marius A @.***> wrote:

In README and at http://futurepress.github.io/epub.js/examples/scrolled.html viewer is hardcoded to specific height/width. These should be left out, so that Viewer takes whole page.

Are height/width required? If so, set the to browser's dimensions.

Examples should work by default on any device size. No need to be responsive, just get dimensions from initial load.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/futurepress/epub.js/issues/1225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB43QDUCXDGQHJKB4G7IADULWK3ZANCNFSM5H52YYRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

OriKuttner avatar Nov 13 '21 07:11 OriKuttner