bollard icon indicating copy to clipboard operation
bollard copied to clipboard

feat: Add connect_with_defaults

Open jalaziz opened this issue 1 year ago • 2 comments

Add connect_with_defaults function that intelligently selects the best connection method to use based on the DOCKER_HOST and DOCKER_TLS_VERIFY environment variables. This mimics the logic of the Docker CLI.

Fixes #310

jalaziz avatar Jan 29 '24 02:01 jalaziz

I have not tested this yet. Hope to do that sometime this coming week.

jalaziz avatar Jan 29 '24 02:01 jalaziz

Thanks for the contribution, I'm away from my computer for a week, but looking through the PR it looks good.

Maybe we can figure out how to test each branch somehow.

fussybeaver avatar Jan 29 '24 18:01 fussybeaver

I think the best way to test the branches is to use the docker DinD image to launch different docker daemons and attempt to connect.

I'll try to set it up this weekend if I can find some time.

jalaziz avatar Feb 03 '24 05:02 jalaziz

Adding tests in #373

fussybeaver avatar Feb 09 '24 21:02 fussybeaver

Thank you and sorry for not getting to the tests myself 🙏🏼

jalaziz avatar Feb 09 '24 21:02 jalaziz

Hate to be this person, but will there be a new release in the near future?

jalaziz avatar Feb 15 '24 20:02 jalaziz

Yeah, we're very close. My only reservation is that we now need to peg to a GitHub revision of the hyperlocal dependency.

fussybeaver avatar Feb 19 '24 15:02 fussybeaver