angular-fusioncharts icon indicating copy to clipboard operation
angular-fusioncharts copied to clipboard

Does not work with angular 14

Open Gillardo opened this issue 2 years ago • 27 comments

Follow the steps on the readme file but use angular 14 and you get this error when trying to run ng serve

image

Gillardo avatar Sep 05 '22 19:09 Gillardo

Here is a sample project, just run npm install and then ng serve and you should replicate the problem

fusion-charts.zip

Gillardo avatar Sep 05 '22 19:09 Gillardo

Is there a plan to start supporting angular 14 soon?

spac-valentin avatar Sep 15 '22 08:09 spac-valentin

As a workaround, you can put the "angular-fusioncharts"'s source code inside you Angular 14 project... And all should works fine

hebus avatar Sep 19 '22 16:09 hebus

@hebus Your workaround got it compiling, but actual loading of charts fails with ERROR TypeError: Cannot read properties of null (reading 'firstCreatePass') at providersResolver (core.mjs:21149:13)

Any thoughts? Should I just use 13?

epiphanizer avatar Sep 22 '22 18:09 epiphanizer

Hello @epiphanizer , Here a stackblitz link: https://stackblitz.com/edit/angular-ivy-32bzyf

Don't worry, if does not work online, just download the source code and test it in local. This is how we have fixed Angular 14 compilation issues

hebus avatar Sep 23 '22 06:09 hebus

@hebus in angular 14 got compile successfully. but while load page throw error. ypeError: Cannot read properties of null (reading 'firstCreatePass'). Is it version issue? how can I resolve.

ajeet2017 avatar Oct 08 '22 06:10 ajeet2017

@fusioncharts We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade. Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now. Please hold an higher release schedule for supporting new versions of Angular.

jerone avatar Oct 12 '22 13:10 jerone

@fusioncharts I've created #154 to upgrade to Angular 14.

jerone avatar Oct 24 '22 09:10 jerone

@fusioncharts please merge #154 and make a new package for us to use.

jprinsloo avatar Nov 09 '22 09:11 jprinsloo

And now we are multiple version behind again, with Angular 15 just released.

I don't know why I pay for this product !!!

jerone avatar Nov 19 '22 19:11 jerone

When I spoke to their support, they didn't even have an ETA, and their claim was - this is an open-source project, so we cannot expect them to deliver or support. unfortunately, they don't seem to know why or how open-source works: they are not even open to merging community patches. Unfortunately, moving away is not a simple decision either :-(

@jerone would it be possible to publish your patched version as an unofficial package?

abishek avatar Nov 22 '22 23:11 abishek

The argument about being an open-source project is confusing. They maintain this repo, plus they mention support for Angular multiple times on their website. 1. 2.

I'll contact them too, asking to prioritize this blocking issue.

[..] they are not even open to merging community patches.

Exactly, the work is already done #154 (if they confirm everything is working correctly).

@jerone would it be possible to publish your patched version as an unofficial package?

I have to think about this and discuss this internally, as I forked this repo from my companies org. I try to stay away from publishing clones, because I cannot and will not give support if we unofficially publish it.

jerone avatar Nov 23 '22 17:11 jerone

Same issue trying to upgrade my app to Angular 14. We only purchased our license due to the fact that they said it "had support for Angular".

Franccescalee avatar Nov 23 '22 19:11 Franccescalee

@Franccescalee commented on Nov 23, 2022, 8:43 PM GMT+1:

@jerone can you add someone as a reviewer? It looks like it would let me approve which is strange. If it is an open-source project who would we reach out to publish your updates?

No, this is impossible, I'm not an admin, member or a collaborator of this repository.

Best thing is to upvote this issue, upvote the referenced PR and contact Fusioncharts.

jerone avatar Nov 23 '22 20:11 jerone

Some activity happening:

  • https://github.com/fusioncharts/angular-fusioncharts/pull/161
  • https://github.com/fusioncharts/angular-fusioncharts/tree/appwrk-master3.20

jerone avatar Dec 20 '22 14:12 jerone

@fusioncharts We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade. Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now. Please hold an higher release schedule for supporting new versions of Angular.

@jerone how did u solved issue on angular 12? I have Cannot read properties of null (reading 'firstCreatePass') issue (on prod only, and only on hosted machine, locally 'prod' build also works, and can't find the solution

unspike avatar Jan 16 '23 07:01 unspike

@unspike I didn't.

This story is about Angular 14 & 15 support.

jerone avatar Jan 16 '23 08:01 jerone

@jerone yeah, but u said

For the previous versions, the upgrade was possible by forcing the upgrade.

can you please clarify what do u mean by that.

unspike avatar Jan 16 '23 08:01 unspike

@unspike ng update --force ...

jerone avatar Jan 16 '23 08:01 jerone

We are also paying customers and we are forced to upgrade to Angular 14. Did anyone managed to work around this issue?

AdiSilagy avatar Feb 05 '23 14:02 AdiSilagy

What a lamentable business. They need to remediate this things to avoid paying for a license for something that you cannot upgrade.

ghost avatar Feb 07 '23 18:02 ghost

We are also paying customers and we are forced to upgrade to Angular 14. Did anyone managed to work around this issue?

@AdiSilagy We had to clone the repository and upgrade it ourselves. Then published to a private NPM package.

Franccescalee avatar Feb 09 '23 21:02 Franccescalee

@Franccescalee , how did you upgrade it? Please, let us know.

yuricamara avatar Mar 15 '23 18:03 yuricamara

@yuricamara I think I just changed the angular packages in the package.json to go to 14.x before I did an npm install. I compared what was in there to what I have in my app as well. Then built/packed/published. I don't remember needing to make any changes to the code.

Franccescalee avatar Mar 16 '23 13:03 Franccescalee

Hello,

The latest version of angular-fusioncharts has just been released that is angular-fusioncharts 4.0.3 . This version supports angular version till the latest one (15). If you want you can upgrade the angular version and test your application.

Here is the npm link : https://www.npmjs.com/package/angular-fusioncharts/v/4.0.3

Demo - https://github.com/AyanBhadury/angular-fusioncharts-sample

AyanBhadury avatar Mar 30 '23 09:03 AyanBhadury

Super great news. I'll give it a try soon. 🎉

Can you please create an CHANGELOG to keep track of the changes. Preferably via the "Releases" tab. Many corporation need to track the changes.

Are there for example no breaking changes? Upgrade guide?

But more important, Angular 16 is less then 1 month away ("week of 2023-05-01").

https://angular.io/guide/releases#release-schedule Please add support for Angular 16 ASAP !!!

jerone avatar Apr 03 '23 07:04 jerone

Sorry I don't have the permission, may be create a ticket to [email protected] and request them to add it.

AyanBhadury avatar Apr 03 '23 08:04 AyanBhadury