paramak

paramak copied to clipboard

running` pip install paramak` produces: ``` Collecting paramak Downloading paramak-0.6.7-py3-none-any.whl (233 kB) |████████████████████████████████| 233 kB 3.2 MB/s Requirement already satisfied: numpy>=1.21.1 in /opt/conda/lib/python3.8/site-packages (from paramak) (1.21.4) Requirement already satisfied: matplotlib>=3.4.2...

RemDelaporteMathurin

Unexpected blanket shape at divertors with large major radius

3

With a large major radius relative to the minor radius, the blanket can form a strange shape and overlap with the TF coils. [Paramak_issue_large_major_radius.pptx](https://github.com/fusion-energy/paramak/files/7704792/Paramak_issue_large_major_radius.pptx)

jamesnha

Paramak should use a JSON Schema

2

In the same way that XML has a parsing schema, so codes know what items to expect in dictionaries, paramak should do the same - https://json-schema.org/ - an external company...

makeclean

check that paramak works with miniforge and if so add it to the options for conda

shimwell

When making on of the examples and converting it to a DAGMC geometry it was necessary to have a large volume tolerance (1000) to match the part in the file....

shimwell

We don't have very clear instructions for using the docker images. This is particularly tricky for docker users who are not familar with the ```-p 8888:8888``` command that is needed...

shimwell

Code of conduct lacks email address

1

The code of conduct file requires the package maintainers to provide an email contact for enforcement. Should be a very straightforward change. https://github.com/fusion-energy/paramak/blob/b5a915a7dffd5fbce6dc2654f4fca15bf90f593d/CODE_OF_CONDUCT.md?plain=1#L59

LiamPattinson

preparing to move to cadquery 2.2

8

Currently the paramak requires cadquery 2.1 There is a really nice importBrep feature in the upcoming CadQuery 2.2 and this feature is essential for the use of Paramak geometry in...

shimwell

CI trigger refractor using paths instead of paths-ignore

3

we currently use this https://github.com/fusion-energy/paramak/blob/bee4f0434309dd3529d320f85d2cc9a819044bc5/.github/workflows/ci_with_install.yml#L11-L17 however this could be replaced with less lines https://github.com/C-bowman/inference-tools/blob/760061e77bdc8ddeacb951196a3deb783a6ccffd/.github/workflows/tests.yml#L5-L6

shimwell

it would be great to add some difference vessel caps like these https://www.wermac.org/equipment/equipment_img/pvheads.gif

shimwell