paramak icon indicating copy to clipboard operation
paramak copied to clipboard

changing method of cutting wedge

Open shimwell opened this issue 4 years ago • 0 comments

Currently a cutting wedge is used in the following way

cutting_wedge = calculate_wedge_cut(self)
solid = self.perform_boolean_operations(solid, wedge_cut=cutting_wedge)

which doesn't work well for extruded shapes or shapes without a radius and height attribute.

We could use this approach instead

largest_dim = get_largest_dimension(solid)
cutting_wedge = CuttingWedge(height=largest_dim*2, radius=largest_dim*2, rotation_angle=360.-self.rotation_angle)

Perhaps as a first stage tests for the volume of all parametric components should be added to a new unit test file. this file would have shapes with 360 rotation and 90 degree rotation and check the volume is 1/4

this will be easier one #229 is complete

shimwell avatar Mar 31 '22 22:03 shimwell