neutronics-workshop icon indicating copy to clipboard operation
neutronics-workshop copied to clipboard

Create example with weight windows

Open shimwell opened this issue 3 years ago • 5 comments

I'm hoping to add an example with weight windows and a mesh tally

I am working on this addition on this branch https://github.com/fusion-energy/neutronics-workshop/tree/adding_ww_task

shimwell avatar Feb 06 '22 22:02 shimwell

a half completed example is now on the develop branch as task 13

I shall come back to this once automatic weight windows are added

shimwell avatar Feb 13 '22 17:02 shimwell

Hello, is there any progress on this? The branch adding_www_task does not seem to be available anymore.

janmalec avatar Nov 18 '22 11:11 janmalec

I've been using weight windows along with the magic method and working on this but we noticed a few bugs when iteratively building up weight windows recently. Patrick merged in some fixes to the development branch of OpenMC.

https://github.com/openmc-dev/openmc/pull/2284 https://github.com/openmc-dev/openmc/pull/2275

I have not yet had time to get back on this task but I have a deadline to finish it before Christmas as I need it elsewhere.

shimwell avatar Nov 18 '22 14:11 shimwell

The branch was merged in and probably deleted. But as it was merged the contents are in the repo

https://github.com/fusion-energy/neutronics-workshop/tree/main/tasks/task_13_variance_reduction

I don't think this task is finished and these examples need a tidy up. I shall fix it up soon

shimwell avatar Nov 18 '22 16:11 shimwell

Just reporting progress, there is an open pull request now to redo task 13

tagging @billingsley-john just in case it is of interest

Here is a link to the new files https://github.com/fusion-energy/neutronics-workshop/tree/updating_vr_example/tasks/task_13_variance_reduction

shimwell avatar Nov 23 '22 21:11 shimwell