fuse-samples icon indicating copy to clipboard operation
fuse-samples copied to clipboard

Published 20 hours ago • verified publisher icon fuse-open

ImageViewer is broken

Open sebbert opened this issue 8 years ago • 5 comments

ImageViewer has a couple of bugs that I don't have the knowledge of how to fix.

  • [ ] - Double tapping to reset the transform and the close button works only while interacting with the Rotate- Zoom- and RotateGestures.
  • [ ] - Rotation gesture often wraps around, resulting in a rotation > 180°, instead of taking the shortest path.
  • [x] - A bunch of TODO comments and confusion regarding removed/renamed/deprecated features

Tested using Android preview, Fuse 0.26.0 (7741)

sebbert avatar Sep 30 '16 11:09 sebbert

The gestures also feals very unnatural and weird.

bondehagen avatar May 05 '17 22:05 bondehagen

@sebbert some of this is fixed in https://github.com/fusetools/fuse-samples/commit/7a78a08a78d5266629fd669909ed6c2e2461330b#diff-76f439ed0cffc2d7d6091816c835f426

bondehagen avatar May 05 '17 23:05 bondehagen

Switching from portrait to landscape is messing up the layout when viewing an image

bondehagen avatar May 08 '17 17:05 bondehagen

@eksperts will take a look at this today

kristianhasselknippe avatar May 09 '17 08:05 kristianhasselknippe

@bondehagen PR in: #59 First it's a general syntax cleanup and associated changes to match best practices. Second, the RotateGesture wrap-around problem was caused by the StepDegrees property; removed it and it's now fine (tried, but could not find a way to eliminate wrap-around by leaving StepDegrees). Could not reproduce the "double tapping" issue @sebbert mentioned, worked fine on a Nexus 5.

eksperts avatar May 09 '17 10:05 eksperts