chrome-tab-modifier icon indicating copy to clipboard operation
chrome-tab-modifier copied to clipboard

Published 20 hours ago • verified publisher icon furybee

Changes script interaction to support SPAs

Open MartinLichtblau opened this issue 5 years ago • 4 comments

@sylouuu I auto formatted the code and created some unnecessary changes. I also didnt't know whether the /dist needs to be generated from the /src when only the content and backround script changed; so I just copied it by hand. So this closes #185 (my isssue) Since it works with SPAs now it fixes #168 fixes #168 fixes #105 fixes #93 fixes #64 Related fixes

  • title isn't changed if dom selector not found: thus fixes #159 fixes #112 fixes #110 Could fix: #177 #158

MartinLichtblau avatar May 17 '19 16:05 MartinLichtblau

@sylouuu What do you think of that commit? I think others would benefit from it.

MartinLichtblau avatar Jun 24 '19 14:06 MartinLichtblau

Hey @sylouuu to remind you to accept this Pull Request.

MartinLichtblau avatar Jul 13 '19 09:07 MartinLichtblau

Gooood morning @sylouuu !!! :_D Any plans to accept this Pull Request?

MartinLichtblau avatar Aug 03 '19 07:08 MartinLichtblau

Hi @MartinLichtblau

Thanks for your work. As I said in https://github.com/sylouuu/chrome-tab-modifier/issues/180 I have no plan to work on TM at the moment. Even if I merge this, I won't release a new version, etc.

Thanks for your understanding!

sylouuu avatar Aug 03 '19 16:08 sylouuu

Hi @MartinLichtblau,

The entire code base has been rewritten. If this is still needed, can you contribute again? Tab Modifier 1.0 is now available!

Feel free to open a new PR,

Bests

sylouuu avatar Jun 08 '24 06:06 sylouuu