chrome-tab-modifier icon indicating copy to clipboard operation
chrome-tab-modifier copied to clipboard

Detection 'ends with' and 'exact' behave like 'contains'

Open pipe1801 opened this issue 6 years ago • 1 comments

Tab Modifier version

Browser: Chrome

Extension version: 0.22.0

Expected behavior

It seems that rules that use the detection method 'ends with' get triggered even when there are more characters following in the title.

The website I want to check: https://mail.google.com/mail/u/0/#inbox/FMGSFDcgxvfgqHPLLxBPTNPGSFDcgxvCprMSvklX

Detection: ends with: 'mail/u/1/#inbox'

Expected result: website is ignored, title stays as before

Actual behavior

The rule gets triggered, when it actually only should fire on this address: https://mail.google.com/mail/u/0/#inbox

Background: first link is an individual e-mail (in which case I do not want to use regexp on parts of the title). Second link is the link to my/any gmail inbox, where the title regexp is very useful, e.g. to use the number of unread e-mails.

But still: awesome extension! Great job!

Best regards,

Bastian

pipe1801 avatar Aug 28 '18 12:08 pipe1801

Hello @pipe1801

Thanks for the report.

I'm almost sure because the last part of the URL is appended after loading? Dynamically. So when TM is processing, the URL isn't complete. It's a common use case for SPAs.

Try with "ends at" and "issues/157". Go to https://github.com/sylouuu/chrome-tab-modifier/issues/157

I can't do anything for that, globally, TM is not working very well on SPAs. I have no plan to work again on TM though.

Best

sylouuu avatar Aug 28 '18 14:08 sylouuu