Wrong boys2rgb colormap

[zhenchen-jay]

Description

I think there is a typo in the function boys2rgb

https://github.com/fury-gl/fury/blob/master/fury/colormap.py#L118

it is actually should be: z4 = z2 * z2

This can be also seen in the initial matlab code: https://cagataydemiralp.io/projects/boys/line2rgb.m

Way to reproduce

• [ ] Code example

import numpy as np
from fury import colormap

if __name__ == '__main__':
    v = np.array([[0.0183422, 0.00418003, 0.999823], [-0.0183422, -0.00418003, -0.999823]])
    print(colormap.boys2rgb(v))

• [ ] Result

[[0.49262681 0.48131988 0.05134322]
 [0.49262681 0.48131988 0.87099833]]

[DanonymousCoder]

Hi, I would love to work on this issue

[DanonymousCoder]

@zhenchen-jay

[zhenchen-jay]

cool. Which additional information I need to provide?

[DanonymousCoder]

Pls, kindly assign me this issue to work on @zhenchen-jay @skoudoro

[zhenchen-jay]

I am not able to do that since I don't have the necessary permission. @DanonymousCoder

[ganimtron-10]

Hey @zhenchen-jay , Thanks for pointing this out.

@DanonymousCoder if you interested, please feel free to go on and create a PR.

[DanonymousCoder]

Already created a pull request @ganimtron-10 . Pls, kindly check.

[ganimtron-10]

Cool @skoudoro @guaje would give a look.

[skoudoro]

will look into it this week, thanks for the review @ganimtron-10

[Preetam-Das26]

hello is this issue active?CAn I work on it? @skoudoro @ganimtron-10

[ganimtron-10]

@Preetam-Das26 This is already picked up by @DanonymousCoder