fury
fury copied to clipboard
UI: Adding FileDialog UI
FileDialog is an important UI element needed for a variety of use case. Continuing #294 to add the required changes and updates.
TODO:
- [ ] ~~Resize for
FileMenu2D
~~. -> in a new PR - [ ] ~~Resize for
FileDialog2D
~~ -> in a new PR - [x] Fix ListBoxItem issue when adding a new element to listbox.
- [x] Fix overflowing issue
- [x] ZeroDivisionError issue
Codecov Report
Merging #832 (b95871b) into master (b29a518) will increase coverage by
0.07%
. Report is 7 commits behind head on master. The diff coverage is89.60%
.
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 84.49% 84.57% +0.07%
==========================================
Files 44 44
Lines 10454 10572 +118
Branches 1411 1419 +8
==========================================
+ Hits 8833 8941 +108
- Misses 1252 1257 +5
- Partials 369 374 +5
Files Changed | Coverage Δ | |
---|---|---|
fury/ui/elements.py | 90.28% <89.60%> (+0.08%) |
:arrow_up: |
What is the update concerning this PR @ganimtron-10?
I have fixed the issues which were crucial and needed in this PR.
@tvcastillod and @JoaoDell, Can you look at this PR ? Thank you
Hey @JoaoDell @tvcastillod , Heres the blog link to get more understanding about what I did in this PR https://blogs.python-gsoc.org/en/ganimtron_10s-blog-copy-2/week-12-filedialog-quest-begins/
Hey @JoaoDell @tvcastillod , Heres the blog link to get more understanding about what I did in this PR https://blogs.python-gsoc.org/en/ganimtron_10s-blog-copy-2/week-12-filedialog-quest-begins/
Just checked your blogpost and I have no more questions. Also I noticed you have fixed the directory textblock clipping, so everything seems in place now, good job